Removes std::function<> from the utility process (Part5).
#19792
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| engine_->RunDBTransaction( | ||
| std::move(transaction), | ||
| base::BindOnce(&DatabaseBalanceReport::OnGetRecord, | ||
| base::Unretained(this), std::move(callback))); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] base::Unretained is most of the time unrequited, and a weak reference is better suited for secure coding.
Consider swapping Unretained for a weak reference.
base::Unretained usage may be acceptable when a callback owner is guaranteed
to be destroyed with the object base::Unretained is pointing to, for example:
- PrefChangeRegistrar
- base::*Timer
- mojo::Receiver
- any other class member destroyed when the class is deallocated
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-uaf.yaml
Cc @thypon @goodov @iefremov
| @@ -31,27 +28,26 @@ void DatabaseInitialize::Start(LegacyResultCallback callback) { | |||
|
|
|||
| engine_->RunDBTransaction( | |||
| std::move(transaction), | |||
| std::bind(&DatabaseInitialize::OnInitialize, this, _1, callback)); | |||
| base::BindOnce(&DatabaseInitialize::OnInitialize, base::Unretained(this), | |||
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] base::Unretained is most of the time unrequited, and a weak reference is better suited for secure coding.
Consider swapping Unretained for a weak reference.
base::Unretained usage may be acceptable when a callback owner is guaranteed
to be destroyed with the object base::Unretained is pointing to, for example:
- PrefChangeRegistrar
- base::*Timer
- mojo::Receiver
- any other class member destroyed when the class is deallocated
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-uaf.yaml
Cc @thypon @goodov @iefremov
| }); | ||
| std::move(transaction), | ||
| base::BindOnce(&DatabaseMigration::RunDBTransactionCallback, | ||
| base::Unretained(this), std::move(callback), start_version, |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] base::Unretained is most of the time unrequited, and a weak reference is better suited for secure coding.
Consider swapping Unretained for a weak reference.
base::Unretained usage may be acceptable when a callback owner is guaranteed
to be destroyed with the object base::Unretained is pointing to, for example:
- PrefChangeRegistrar
- base::*Timer
- mojo::Receiver
- any other class member destroyed when the class is deallocated
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-uaf.yaml
Cc @thypon @goodov @iefremov
| @@ -27,16 +26,18 @@ void Report::GetMonthly(const mojom::ActivityMonth month, | |||
| const int year, | |||
| GetMonthlyReportCallback callback) { | |||
| auto balance_callback = | |||
| std::bind(&Report::OnBalance, this, _1, _2, month, year, callback); | |||
| base::BindOnce(&Report::OnBalance, base::Unretained(this), month, year, | |||
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] base::Unretained is most of the time unrequited, and a weak reference is better suited for secure coding.
Consider swapping Unretained for a weak reference.
base::Unretained usage may be acceptable when a callback owner is guaranteed
to be destroyed with the object base::Unretained is pointing to, for example:
- PrefChangeRegistrar
- base::*Timer
- mojo::Receiver
- any other class member destroyed when the class is deallocated
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-uaf.yaml
Cc @thypon @goodov @iefremov
| LegacyResultCallback finish_callback = std::bind( | ||
| &RewardsEngineImpl::OnInitialized, this, _1, std::move(callback)); | ||
| auto finish_callback = | ||
| base::BindOnce(&RewardsEngineImpl::OnInitialized, base::Unretained(this), |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] base::Unretained is most of the time unrequited, and a weak reference is better suited for secure coding.
Consider swapping Unretained for a weak reference.
base::Unretained usage may be acceptable when a callback owner is guaranteed
to be destroyed with the object base::Unretained is pointing to, for example:
- PrefChangeRegistrar
- base::*Timer
- mojo::Receiver
- any other class member destroyed when the class is deallocated
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-uaf.yaml
Cc @thypon @goodov @iefremov
|
|
||
| auto database_callback = | ||
| base::BindOnce(&RewardsEngineImpl::OnDatabaseInitialized, | ||
| base::Unretained(this), std::move(finish_callback)); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] base::Unretained is most of the time unrequited, and a weak reference is better suited for secure coding.
Consider swapping Unretained for a weak reference.
base::Unretained usage may be acceptable when a callback owner is guaranteed
to be destroyed with the object base::Unretained is pointing to, for example:
- PrefChangeRegistrar
- base::*Timer
- mojo::Receiver
- any other class member destroyed when the class is deallocated
Source: https://github.com/brave/security-action/blob/main/assets/semgrep_rules/c/chromium-uaf.yaml
Cc @thypon @goodov @iefremov
szilardszaloki
deleted the
szilard-32400-removes-std-function-from-the-utility-process-part5
branch
Resolves brave/brave-browser#32400.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: